Skip to content

Conversation

@hisushanta
Copy link
Contributor

I noticed an issue in the issue section and addressed it by adding a small code snippet.

Fixes #27513

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@hisushanta
Copy link
Contributor Author

I'm always looking for ways to improve my code, so please don't hesitate to share your thoughts.

@amyeroberts
Copy link
Contributor

@hi-sushanta It all looks good to me! I can see there's an error on the documentation build unrelated to this PR. Last week there was a fix pushed to main. Could you rebase to include that and trigger another CI run? Once all green we should be good to merge!

@amyeroberts
Copy link
Contributor

@hi-sushanta I think the quality failures are coming from some recent changes to our formatting in the library: we've recently started using ruff instead of black. To align with the updates you'll need to:

  • Uninstall black: pip uninstall black
  • Install any needed updates: pip install -e .[quality]
  • Re-run formatting: make fixup

@hisushanta
Copy link
Contributor Author

now all checked pass.

@amyeroberts amyeroberts merged commit 29c9480 into huggingface:main Nov 24, 2023
@hisushanta hisushanta deleted the bug_fix branch November 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZeroDivisionError in NotebookProgressBar

2 participants