Skip to content

Conversation

@NoB0
Copy link
Contributor

@NoB0 NoB0 commented Nov 22, 2023

What does this PR do?

Translated the quicktour.mdx file of the documentation to French.

Part of #21456

Thank you in advance for your review.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

French speaking contributors.
Documentation: @stevhliu and @MKhalusova

@NoB0 NoB0 marked this pull request as ready for review November 22, 2023 17:07
@NoB0 NoB0 mentioned this pull request Nov 22, 2023
10 tasks
@CharbelAD
Copy link
Contributor

CharbelAD commented Nov 23, 2023

Heads up, a few typos I was able to spot:

  • line 31: missing 's' -> environnements
  • line 57: en seule ligne -> en une seule ligne
  • line 74 : suivant -> suivants
  • line 110: utilie -> utile

@NoB0 NoB0 changed the title Documentation/fr translation installation [i18n-fr] Translate installation to French Nov 23, 2023
@NoB0
Copy link
Contributor Author

NoB0 commented Nov 23, 2023

Heads up, a few typos I was able to spot:

  • line 31: missing 's' -> environnements
  • line 57: en seule ligne -> en une seule ligne
  • line 74 : suivant -> suivants
  • line 110: utilie -> utile

Thanks for pointing this out! I corrected them and checked for others, I believe it is now ok.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@MKhalusova
Copy link
Contributor

Thank you for working on this! Please make sure the CI checks are green. You can find more information here https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation! Looks good to me as far as structure goes, and to my limited understanding of French.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating


## Installation avec conda

Installation avec la chaîne `huggingface` de conda :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm the channel does not translate to chaine in this case but rather canal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with canal.


</Tip>

Par example, vous exécuteriez généralement un programme sur un réseau normal cloisonné des instances externes avec la commande suivante :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complicated way of saying that you are running something under proxy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that is particular sentence was removed from the English documentation. I updated the content to match the English documentation. I am a bit unsure about the translation of the last sentence (i.e., Seuls les fichiers ...), please check.

@NoB0 NoB0 requested a review from ArthurZucker November 30, 2023 16:56
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation!

@ArthurZucker ArthurZucker merged commit cf62539 into huggingface:main Dec 1, 2023
@NoB0 NoB0 deleted the documentation/fr-translation-installation branch December 1, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants