Fix bug of _prepare_4d_attention_mask #27847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiqing-feng
changed the title
ArthurZucker
approved these changes
Dec 5, 2023
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
The failing CI is related to the styling, make style should help
| "Calling `transformers.models.llama.modeling_llama._prepare_4d_attention_mask` is deprecated and will be removed in v4.37. Use `transformers.modeling_attn_mask_utils.AttentionMaskConverter._prepare_4d_attention_mask" | ||
| ) | ||
| return AttentionMaskConverter._prepare_4d_attention_mask(mask=mask, dtype=dtype, tgt_len=tgt_len) | ||
| return _prepare_4d_attention_mask(mask=mask, dtype=dtype, tgt_len=tgt_len) |
Collaborator
There was a problem hiding this comment.
this is deprecated anyway, but good catch.
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Nice catch! I left one comment, for the failing CI can you try to merge with main and make sure you have ruff==0.1.5 installed when running make fixup ?
Contributor
Author
|
Hi @ArthurZucker @younesbelkada . All CIs are green, would you please help me review and merge it? Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ArthurZucker @younesbelkada . Since
_prepare_4d_attention_maskis no longer a member function ofAttentionMaskConverter, I directly import_prepare_4d_attention_maskfrommodeling_attn_mask_utils. Would you please help to review it? Thx!BTW, the failed CIs are not related to my changes