Skip to content

fix resuming from ckpt when using FSDP with FULL_STATE_DICT #27891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2023
Merged

fix resuming from ckpt when using FSDP with FULL_STATE_DICT #27891

merged 4 commits into from
Dec 16, 2023

Conversation

@pacman100
Copy link
Contributor

@pacman100 pacman100 commented Dec 7, 2023 •
edited
Loading

@pacman100 pacman100 changed the title fix resuming from ckpt when suing FSDP with FULL_STATE_DICT fix resuming from ckpt when using FSDP with FULL_STATE_DICT Dec 7, 2023
@pacman100 pacman100 marked this pull request as ready for review December 15, 2023 18:02
muellerzr
muellerzr approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

amyeroberts
amyeroberts approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@pacman100 pacman100 merged commit 238d2e3 into main Dec 16, 2023
@pacman100 pacman100 deleted the smangrul/fix-fsdp-full-state-dict-resume branch December 16, 2023 14:11
amyeroberts pushed a commit that referenced this pull request Dec 18, 2023
@pacman100 @amyeroberts
fix resuming from ckpt when using FSDP with FULL_STATE_DICT (#27891)
64bcf77 
* fix resuming from ckpt when suing FSDP with FULL_STATE_DICT

* update tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@muellerzr muellerzr muellerzr approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fail to resume training from Pytorch FSDP checkpoint.

5 participants

@pacman100 @HuggingFaceDocBuilderDev @muellerzr @amyeroberts