Add integration tests lm generate torch tf #3191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Mar 9, 2020
Member
|
Approx. how long do these tests take on a single V100? |
Contributor
Author
Don't know how long they take on a V100. On a cpu, all tests combined (7 model tests for PT and 6 model tests for TF) take less than 10min (whereas |
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
==========================================
+ Coverage 78.15% 78.16% +0.01%
==========================================
Files 98 98
Lines 16641 16641
==========================================
+ Hits 13006 13008 +2
+ Misses 3635 3633 -2
Continue to review full report at Codecov.
|
julien-c
approved these changes
Mar 9, 2020
LysandreJik
approved these changes
Mar 9, 2020
|
|
||
| tensor = inputs_embeds + self.position_embeddings(position_ids) | ||
| if langs is not None and self.use_lang_emb: | ||
| if langs is not None and self.use_lang_emb and self.n_langs > 1: |
Contributor
Author
|
Good to merge for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests for all LM models that are able to generate language.
do_sample=False(greedy) generation and verify that TF 2.0 and PT yield the same results.