Skip to content

Test fetcher: missing return on filtered tests; don't write empty files #33224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Test fetcher: missing return on filtered tests; don't write empty files #33224

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ef3836
missing return
gante Aug 30, 2024
1c39d96
skip files without contents
gante Aug 30, 2024
50e9529
test 2
gante Aug 30, 2024
dee1209
dbg
gante Aug 30, 2024
2633cf2
dbg
gante Aug 30, 2024
fa04f15
how about this?
gante Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions utils/tests_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,7 @@ def filter_tests(tests, module=""):
or "/".join(Path(t).parts[1:3]) in module
):
filtered_tests += [t]
return filtered_tests

return {
module: (filter_tests(tests, module=module) if has_many_models(tests) else tests)
Expand Down Expand Up @@ -1159,8 +1160,9 @@ def create_test_list_from_filter(full_test_list, out_path):
else:
files_to_test = list(re.findall(_filter, all_test_files))
print(job_name, file_name)
with open(file_name, "w") as f:
f.write("\n".join(files_to_test))
if len(files_to_test) > 0: # No tests -> no file with test list
with open(file_name, "w") as f:
f.write("\n".join(files_to_test))


if __name__ == "__main__":
Expand Down