[Bart/Memory] SelfAttention only returns weights if config.output_attentions #3369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
SelfAttentionwould always returnattn_weights, and thenBartDecoderandBartEncoderwould decide whether to return them to the user.The
attn_weightstensor is fairly large, with shape =(bs, num_heads, tgt_len, src_len)This meant that the memory allocated for
attn_weightscould not be freed until after the forward pass ofBartDecoder.Now:
SelfAttentionreturns (output, None) ifconfig.output_attentions=Falseand the memory can be freedImpact: memory can be freed after SelfAttention returns. -600MB peak GPU consumption for batch_size=6, tgt_len=src_len=1024, num_heads=16
Speed impact: negligible