Add T5 to docs #3461
Merged
Add T5 to docs #3461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
force-pushed
the
t5_documentation
branch
from
efa2444 to
c808ded
Compare
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
=======================================
Coverage 77.79% 77.80%
=======================================
Files 100 100
Lines 17049 17051 +2
=======================================
+ Hits 13264 13267 +3
+ Misses 3785 3784 -1
Continue to review full report at Codecov.
|
4 tasks
docs/source/model_doc/t5.rst
Outdated
There was a problem hiding this comment.
@thomwolf @LysandreJik - Could you maybe check the Tips?
src/transformers/modeling_bart.py
Outdated
There was a problem hiding this comment.
Added encoder_outputs as input argument @sshleifer
src/transformers/modeling_t5.py
Outdated
There was a problem hiding this comment.
In general I changed the docstring to "Bert"-style docstring since Bert seems to have the cleanest docstrings. @thomwolf
patrickvonplaten
force-pushed
the
t5_documentation
branch
from
f231dee to
0de7b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modeling_t5.pyandmodeling_tf_t5.py