[T5] fix lm lables in docstring #3529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3529 +/- ##
==========================================
+ Coverage 77.80% 77.81% +0.01%
==========================================
Files 100 100
Lines 17062 17062
==========================================
+ Hits 13275 13277 +2
+ Misses 3787 3785 -2
Continue to review full report at Codecov.
|
thomwolf
reviewed
Mar 30, 2020
| Labels for computing the sequence classification/regression loss. | ||
| Indices should be in :obj:`[0, ..., config.vocab_size - 1]`. | ||
| Indices should be in :obj:`[-100, 0, ..., config.vocab_size - 1]`. | ||
| If :obj:`config.num_labels > 1` a classification loss is computed (Cross-Entropy). |
There was a problem hiding this comment.
Should we keep this num_labels mention in the docstring?
There was a problem hiding this comment.
True, T5 is completely independent from num_labels -> should delete this statement.
thomwolf
reviewed
Mar 30, 2020
Comment on lines
+905
to
+906
| All labels set to ``-100`` are ignored (masked), the loss is only | ||
| computed for labels in ``[0, ..., config.vocab_size]`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better explanation to T5
lm_labelsdosctring.