Fix RoBERTa/XLNet Pad Token in run_multiple_choice.py #3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`convert_examples_to_fes atures` sets `pad_token=0` by default, which is correct for BERT but incorrect for RoBERTa (`pad_token=1`) and XLNet (`pad_token=5`). I think the other arguments to `convert_examples_to_features` are correct, but it might be helpful if someone checked who is more familiar with this part of the codebase.
Codecov Report
@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 78.30% 78.28% -0.02%
==========================================
Files 104 104
Lines 17627 17627
==========================================
- Hits 13802 13800 -2
- Misses 3825 3827 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert_examples_to_fes aturessetspad_token=0by default, which is correct for BERT but incorrect for RoBERTa (pad_token=1) and XLNet (pad_token=5). I think the other arguments toconvert_examples_to_featuresare correct, but it might be helpful if someone checked who is more familiar with this part of the codebase.