Skip to content

Conversation

@patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 5, 2020

Wrong argument order of function. Thanks @dmytyar !

@patrickvonplaten patrickvonplaten changed the title fix argument order [TransfoXL] fix argument order of update_mems fn in TF version Apr 5, 2020
@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #3637 into master will increase coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3637      +/-   ##
==========================================
+ Coverage   77.34%   78.29%   +0.94%     
==========================================
  Files         104      104              
  Lines       17628    17628              
==========================================
+ Hits        13634    13801     +167     
+ Misses       3994     3827     -167     
Impacted Files Coverage Δ
src/transformers/modeling_tf_transfo_xl.py 89.15% <100.00%> (ø)
src/transformers/modeling_tf_utils.py 93.45% <0.00%> (+0.16%) ⬆️
src/transformers/modeling_openai.py 81.54% <0.00%> (+1.34%) ⬆️
src/transformers/modeling_xlnet.py 75.77% <0.00%> (+2.29%) ⬆️
src/transformers/modeling_ctrl.py 98.24% <0.00%> (+2.63%) ⬆️
src/transformers/modeling_roberta.py 95.71% <0.00%> (+10.00%) ⬆️
src/transformers/modeling_tf_pytorch_utils.py 89.93% <0.00%> (+81.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab8ab4...8db7ebd. Read the comment docs.

@patrickvonplaten patrickvonplaten merged commit 1789c7d into huggingface:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong parameters order in TFTransfoXLMainLayer _update_mems call

2 participants