Fix dotted model names #40745
Merged
Fix dotted model names #40745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @August-murr, can you add a test that breaks on older versions, that we can use to verify that this works and is fixing the problem? |
|
@Rocketknight1 Also, Copilot suggested adding |
Rocketknight1
approved these changes
Sep 10, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
5 tasks
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
* Fix module loading for models with dots in names * quality check * added test * wrong import * Trigger CI rerun after making test model public * Update src/transformers/dynamic_module_utils.py * Update tests/utils/test_dynamic_module_utils.py * Update tests/utils/test_dynamic_module_utils.py * Move test * make fixup --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Matt <[email protected]>
5 tasks
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
Oct 4, 2025
* Fix module loading for models with dots in names * quality check * added test * wrong import * Trigger CI rerun after making test model public * Update src/transformers/dynamic_module_utils.py * Update tests/utils/test_dynamic_module_utils.py * Update tests/utils/test_dynamic_module_utils.py * Move test * make fixup --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #40496
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1