[ModularChecker] QOL for the modular checker
#41361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molbap
approved these changes
Oct 6, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Looks super nice, thanks!
Comment on lines
+280
to
+286
| snapshot_path = snapshot_download(repo_id=self.hub_dataset, repo_type="dataset") | ||
| snapshot_dir = Path(snapshot_path) | ||
| missing = [ | ||
| fname for fname in (EMBEDDINGS_PATH, INDEX_MAP_PATH, TOKENS_PATH) if not (snapshot_dir / fname).exists() | ||
| ] | ||
| if missing: | ||
| raise FileNotFoundError("Missing expected files in Hub snapshot: " + ", ".join(missing)) |
utils/modular_model_detector.py
Outdated
| dict[str, str]: mapping of model_id -> ISO date string (YYYY-MM-DD). | ||
| Files without a match are simply omitted. | ||
| """ | ||
| import transformers |
Contributor
There was a problem hiding this comment.
Suggested change
| import transformers |
utils/modular_model_detector.py
Outdated
Comment on lines
601
to
606
| for md_path in root.glob("*.md"): | ||
| try: | ||
| text = md_path.read_text(encoding="utf-8", errors="ignore") | ||
| except Exception: | ||
| # Skip unreadable files quietly | ||
| continue |
Contributor
There was a problem hiding this comment.
we can log the file to INFO I suppose
Comment on lines
660
to
668
| try: | ||
| source = file_path.read_text(encoding="utf-8") | ||
| except (FileNotFoundError, OSError): | ||
| return {} | ||
|
|
||
| try: | ||
| tree = ast.parse(source) | ||
| except SyntaxError: | ||
| return {} |
Contributor
There was a problem hiding this comment.
curious, why the try/catch patterns here? Fine to keep them though
Collaborator
Author
There was a problem hiding this comment.
Codex going crazy heaha
Collaborator
Author
There was a problem hiding this comment.
but it does allow us to keep going on the script
| parser = argparse.ArgumentParser(prog="hf-code-sim") | ||
| parser.add_argument("--build", action="store_true") | ||
| parser.add_argument("--modeling-file", type=str) | ||
| parser.add_argument("--modeling-file", type=str, help='You can just specify "vits" if you are lazy like me.') |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
* update * fancy table fancy prints * download to cache folder, never need it everagain * stule * update based on review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?