Modernize CLIP modeling code #41546
Merged
Modernize CLIP modeling code #41546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
cc @zucchini-nlp if you want to take a look! |
zucchini-nlp
approved these changes
Oct 20, 2025
|
run-slow: clip, metaclip_2 |
|
This comment contains run-slow, running the specified jobs: models: ['models/clip', 'models/metaclip_2'] |
|
run-slow: clip, metaclip_2 |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: clip, metaclip_2 |
|
This comment contains run-slow, running the specified jobs: models: ['models/clip', 'models/metaclip_2'] |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* stranded * update modular * modularities * update * fx broken * fx stillb roken * update * missed this * fix metaclip
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* stranded * update modular * modularities * update * fx broken * fx stillb roken * update * missed this * fix metaclip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title. Adds the nice recent modeling utils to CLIP. Was motivated to be able to use it in the looong-standing #33962 .