Update Payload to be a trait alias of http_body::Body
#1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <[email protected]>
LucioFranco
commented
Aug 20, 2019
seanmonstar
reviewed
Aug 20, 2019
seanmonstar
reviewed
Aug 20, 2019
seanmonstar
reviewed
Aug 20, 2019
|
Looks good. I notice using the |
|
@seanmonstar yeah, I was thinking the same, will update http body then this PR. |
|
With hyperium/http-body#14 merged, this can just use |
|
@seanmonstar ok I applied the changes, and I think this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Payload to be a trait alias of http_body::Body and seals Payload so that the only way to implement it is via http_body::Body.
content_lengthwas also removed in favor of the more flexible size hint api in http body.If we're all happy with this I can cut a release of http body and push the cargo.toml change.
cc @seanmonstar @carllerche
Signed-off-by: Lucio Franco [email protected]