Initial push to add tower based clients #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <[email protected]>
LucioFranco
commented
Aug 27, 2019
| type Request = Request<B>; | ||
| type Response = Response; | ||
| type Error = ::Error; | ||
| impl<B> Service<Request<B>> for SendRequest<B> |
There was a problem hiding this comment.
I am thinking we should rename this to Connection<B> and Background<T, B> for the old Connection.
There was a problem hiding this comment.
I'm undecided. Is there an issue with the current naming?
There was a problem hiding this comment.
I feel that Service1<Service2<Connection<Request>>> seems much better than Service1<Service2<SendRequest<Request>>> thats really it.
LucioFranco
commented
Aug 27, 2019
seanmonstar
reviewed
Aug 29, 2019
|
@seanmonstar Ok, I think this is ready all deps brought in are published as well. I think this supports the most minimal api I need. |
davidbarsky
reviewed
Aug 30, 2019
|
@LucioFranco does it build with |
|
@DoumanAsh yes |
seanmonstar
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, need to get crates out for MakeService and MakeConnection.
This mainly introduces the most minimal change to support tower based clients.
cc @seanmonstar