Skip to content

Fix labels in Display for Status #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
Merged

Fix labels in Display for Status #2414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tonic/src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,10 +748,10 @@ impl From<std::io::Error> for Status {

impl fmt::Display for Status {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "status: '{}'", self.code())?;
write!(f, "code: '{}'", self.code())?;
Copy link

@kloakin kloakin Sep 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code may be more clear
but the old format string was "status: {:?}, message: {:?}, details: {:?}, metadata: {:?}"
so I think either one might be ok


if !self.message().is_empty() {
write!(f, ", self: {:?}", self.message())?;
write!(f, ", message: {:?}", self.message())?;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

}
// We intentionally omit `self.details` since it's binary data, not fit for human eyes.
if !self.metadata().is_empty() {
Expand Down
Loading