warning invalid sync mode option [#3884] #4017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picocli already handles Enums in their built-in converter. The custom converter allows invalid values to be passed and these are converted to null which is considered valid by the converter and will not trigger alert to the user. Resolves: hyperledger#3884 Signed-off-by: Gabriel Fukushima <[email protected]>
After removed the call of the registering custom converters from the command line method is not being used anymore. Resolves: hyperledger#3884 Signed-off-by: Gabriel Fukushima <[email protected]>
Invalid sync-mode was converted to fast previously, now it throws an alert to the user warning about expected valid entries. Resolves: hyperledger#3884 Signed-off-by: Gabriel Fukushima <[email protected]>
macfarla
approved these changes
Jun 27, 2022
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution!
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Sally MacFarlane <[email protected]>
lucassaldanha
pushed a commit
to lucassaldanha/besu
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Gabriel Fukushima <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Warning displayed to the user when an invalid sync-mode option passed to besu.
Removed the custom converter that was allowing invalid options to be passed converting them to null in the end.
Fixed Issue(s)
Fixes #3884
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog