Delegate all the block checks and validation to the block import phase #4098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
invalid-number-block-from-sync
branch
from
11d9ad9 to
a0ef3f1
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
invalid-number-block-from-sync
branch
from
a0ef3f1 to
b53ef72
Compare
garyschulte
approved these changes
Jul 13, 2022
# Conflicts: # CHANGELOG.md # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardChain.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/InMemoryBackwardChainTest.java
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
hyperledger#4098) Signed-off-by: Fabio Di Fabio <[email protected]>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
hyperledger#4098) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Cody Born <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
hyperledger#4098) Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio [email protected]
PR description
Remove preventive checks during sync, since they will be performed always performed during the import phase later, where the block will be also flagged as bad block.
With this the last failing Hive test (Invalid Ancestor Chain Re-Org, Invalid Number, Invalid P9', Reveal using sync) passes.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog