Skip to content

I frame widget created #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 16, 2022
Merged

I frame widget created #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6debde7
feat: iframe widget created
jyothishjose6190 Feb 13, 2022
93b23ab
feat: iframe widget - updated test cases
jyothishjose6190 Feb 13, 2022
3acba52
feat: iframe widget - lint errors fixed
jyothishjose6190 Feb 13, 2022
90e9b28
feat: iframe widget - lint errors fixed
jyothishjose6190 Feb 13, 2022
82d1d9c
feat: iframe widget - comments
jyothishjose6190 Feb 15, 2022
d4065b3
feat: iframe widget - lint errors fixed
jyothishjose6190 Feb 15, 2022
5fd5453
feat: iframe widget - lint errors fixed
jyothishjose6190 Feb 15, 2022
59b161a
Merge branch 'main' into i-frame
jyothishjose6190 Feb 15, 2022
1f212c6
feat: iframe widget - comments
jyothishjose6190 Feb 15, 2022
df7f8cd
Merge branch 'i-frame' of github.com:razorpay/hypertrace-ui into i-frame
jyothishjose6190 Feb 15, 2022
1d74c80
Merge branch 'main' into i-frame
jyothishjose6190 Feb 15, 2022
a2d6dc0
Merge branch 'main' into i-frame
jyothishjose6190 Feb 16, 2022
c2158de
feat: iframe widget - comments
jyothishjose6190 Feb 16, 2022
162d6a0
feat: iframe widget - comments
jyothishjose6190 Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cts/observability/src/shared/dashboard/widgets/iframe/iframe-widget-renderer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export class IframeWidgetRendererComponent extends WidgetRenderer<IFrameWidgetMo
public urlSafe?: SafeResourceUrl;

public constructor(
public sanitizer: DomSanitizer,
private readonly sanitizer: DomSanitizer,
@Inject(RENDERER_API) api: RendererApi<IFrameWidgetModel>,
changeDetector: ChangeDetectorRef
) {
Expand Down
1 change: 0 additions & 1 deletion projects/observability/src/shared/dashboard/widgets/iframe/iframe-widget.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { IFrameWidgetModel } from './iframe-widget.model';
declarations: [IframeWidgetRendererComponent],
imports: [
CommonModule,

DashboardCoreModule.with({
models: [IFrameWidgetModel],
renderers: [IframeWidgetRendererComponent]
Expand Down