Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jan 22, 2021

Description

Please include a summary of the change, motivation and context.
refactor: setting min dropdown width to be equal to trigger width

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner January 22, 2021 20:44
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #524 (68324a4) into main (f080288) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         757      757           
  Lines       15518    15518           
  Branches     1839     1839           
=======================================
  Hits        13284    13284           
  Misses       2203     2203           
  Partials       31       31           
Impacted Files Coverage Δ
...ponents/src/multi-select/multi-select.component.ts 95.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f080288...68324a4. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 8dc4b72 into main Jan 22, 2021
@anandtiwary anandtiwary deleted the multi-select-width branch January 22, 2021 22:14
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   12m 32s ⏱️ +31s
818 tests ±0  818 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
822 runs  ±0  822 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8dc4b72. ± Comparison against base commit f080288.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants