Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Feb 24, 2021

Description

This PR removes the double icons present in the breadcrumbs and the header, particularly in ht-page-header also to show or not the icons in the crumbs following the first crumb.

Testing

Visual verification

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner February 24, 2021 23:03
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #637 (dcfc3d3) into main (cf92899) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #637   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files         775      775           
  Lines       15979    15979           
  Branches     2059     2059           
=======================================
  Hits        13616    13616           
  Misses       2329     2329           
  Partials       34       34           
Impacted Files Coverage Δ
...omponents/src/breadcrumbs/breadcrumbs.component.ts 94.11% <ø> (ø)
...omponents/src/header/page/page-header.component.ts 100.00% <ø> (ø)
...ckend-detail/backend-detail-breadcrumb.resolver.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf92899...dcfc3d3. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Patricio Albizu added 2 commits February 25, 2021 19:35
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit c20063b into main Feb 26, 2021
@palbizu palbizu deleted the RemovePrimaryIcon branch February 26, 2021 19:16
@github-actions
Copy link

Unit Test Results

    4 files  ±0  239 suites  ±0   15m 21s ⏱️ +33s
862 tests +1  862 ✔️ +1  0 💤 ±0  0 ❌ ±0 
866 runs  +1  866 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit c20063b. ± Comparison against base commit cf92899.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants