Skip to content

Conversation

@anandtiwary
Copy link
Contributor

Reverts #668

@anandtiwary anandtiwary requested a review from a team as a code owner March 9, 2021 22:32
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #671 (2bb49fe) into main (1b74046) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files         779      779           
  Lines       16042    16042           
  Branches     2068     2068           
=======================================
  Hits        13674    13674           
  Misses       2333     2333           
  Partials       35       35           
Impacted Files Coverage Δ
projects/components/src/table/table.component.ts 91.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b74046...2bb49fe. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take it that it didn't work?

@anandtiwary
Copy link
Contributor Author

It had create another PR to fix a side effect. I later realized it is not worth the time to make further changes. There is an alternative which is to set min-height:0 in the parent container (at the usage side).

@anandtiwary anandtiwary merged commit 52befc5 into main Mar 9, 2021
@anandtiwary anandtiwary deleted the revert-668-table-flex-container branch March 9, 2021 22:42
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Unit Test Results

    4 files  ±0  243 suites  ±0   14m 29s ⏱️ -9s
872 tests ±0  872 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
876 runs  ±0  876 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 52befc5. ± Comparison against base commit 1b74046.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants