fix: removing Filtering for exit calls cell in trace table #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 789 789
Lines 16145 16145
Branches 2060 2060
=======================================
Hits 13785 13785
Misses 2329 2329
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }) | ||
| export class ExitCallsTableCellRendererComponent extends TableCellRendererBase<CellData, Trace> implements OnInit { | ||
| public readonly apiCalleeNameCount: string[][]; | ||
| public readonly apiCalleeNameEntires: [string, string][]; |
There was a problem hiding this comment.
Suggested change
| public readonly apiCalleeNameEntires: [string, string][]; | |
| public readonly apiCalleeNameEntries: [string, string][]; |
(and references)
| public readonly apiExitCalls: number; | ||
| public readonly maxShowApiCalleeNameCount: number = 10; | ||
| public readonly totalCountOfDifferentApiCallee!: number; | ||
| public readonly MAX_API_CALLEE_TO_SHOW: number = 10; |
There was a problem hiding this comment.
With a const like this, we should make it static (and lift it above the instance vars)
There was a problem hiding this comment.
also, please rename to MAX_API_CALLEES_TO_SHOW
arjunlalb
reviewed
Apr 15, 2021
| public readonly maxShowApiCalleeNameCount: number = 10; | ||
| public readonly totalCountOfDifferentApiCallee!: number; | ||
| public readonly MAX_API_CALLEE_TO_SHOW: number = 10; | ||
| public readonly uniqueApiCallee: number; |
There was a problem hiding this comment.
I'd recommend uniqueApiCalleeCount
| public readonly apiExitCalls: number; | ||
| public readonly maxShowApiCalleeNameCount: number = 10; | ||
| public readonly totalCountOfDifferentApiCallee!: number; | ||
| public readonly MAX_API_CALLEE_TO_SHOW: number = 10; |
There was a problem hiding this comment.
also, please rename to MAX_API_CALLEES_TO_SHOW
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Apr 15, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing Filtering for exit calls cell in trace table
Testing
Local testing done
Checklist: