feat: adding explore filter link component #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 85.39% 85.40%
=======================================
Files 789 791 +2
Lines 16145 16155 +10
Branches 2060 2060
=======================================
+ Hits 13787 13797 +10
Misses 2327 2327
Partials 31 31
Continue to review full report at Codecov.
|
aaron-steinfeld
previously approved these changes
Apr 16, 2021
| </ht-link> | ||
| ` | ||
| }) | ||
| export class ExploreFilterLinkComponent { |
There was a problem hiding this comment.
Feels a bit weird to call this explore filter link when it doesn't reference explorer, it just adds a filter icon around a provided link + content.
There was a problem hiding this comment.
The icon type should be more specific to explorer.
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Apr 16, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
feat: adding explore filter link component
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.