Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented May 12, 2021

Description

Please include a summary of the change, motivation and context.
fix: link updates for tracing and entity renderers

  • tracing service now exposes navigation params to be used with ht-link
  • entity renderers now uses navigation params with ht-link

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

- tracing service now exposes navigation params to be used with ht-link
- entity renderers now uses navigation params with ht-link
@anandtiwary anandtiwary requested a review from a team as a code owner May 12, 2021 23:32
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #845 (cb33c82) into main (491704c) will increase coverage by 0.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   85.46%   85.47%   +0.01%     
==========================================
  Files         796      796              
  Lines       16298    16310      +12     
  Branches     1937     1940       +3     
==========================================
+ Hits        13929    13941      +12     
  Misses       2337     2337              
  Partials       32       32              
Impacted Files Coverage Δ
...ces/navigation/entity/entity-navigation.service.ts 96.29% <90.00%> (+0.46%) ⬆️
.../services/navigation/tracing-navigation.service.ts 100.00% <100.00%> (ø)
...nents/entity-renderer/entity-renderer.component.ts 100.00% <100.00%> (ø)
...mponents/entity-renderer/entity-renderer.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491704c...cb33c82. Read the comment docs.

@github-actions

This comment has been minimized.

jake-bassett
jake-bassett previously approved these changes May 12, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

arjunlalb
arjunlalb previously approved these changes May 13, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 9845c35 into main May 13, 2021
@anandtiwary anandtiwary deleted the api-flow-tracing branch May 13, 2021 05:58
@github-actions
Copy link

Unit Test Results

    4 files  ±0  252 suites  ±0   15m 28s ⏱️ -59s
906 tests +5  906 ✔️ +5  0 💤 ±0  0 ❌ ±0 
912 runs  +5  912 ✔️ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 9845c35. ± Comparison against base commit 491704c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants