Skip to content

Verify message, signature and pubkey lengths for ed25519-verify #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Verify message, signature and pubkey lengths for ed25519-verify #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ export const MAX_LENGTH_DB_VALUE: number = 128 * 1024;
export const MAX_LENGTH_CANONICAL_ADDRESS: number = 64;
export const MAX_LENGTH_HUMAN_ADDRESS: number = 256;

export const MAX_LENGTH_ED25519_SIGNATURE: number = 64;
export const MAX_LENGTH_ED25519_MESSAGE: number = 128 * 1024;
export const EDDSA_PUBKEY_LEN: number = 32;

export class VMInstance {
public instance?: WebAssembly.Instance;
public bech32: BechLib;
Expand Down Expand Up @@ -378,6 +382,10 @@ export class VMInstance {
signature: Region,
pubkey: Region
): number {
if (message.length > MAX_LENGTH_ED25519_MESSAGE) return 1;
if (signature.length > MAX_LENGTH_ED25519_SIGNATURE) return 1;
if (pubkey.length > EDDSA_PUBKEY_LEN) return 1;

const sig = Buffer.from(signature.data).toString('hex');
const pub = Buffer.from(pubkey.data).toString('hex');
const msg = Buffer.from(message.data).toString('hex');
Expand Down
2 changes: 1 addition & 1 deletion test/imports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ describe('do_ed25519_verify', () => {
expect(result).toEqual(1);
});

it.skip('fails for large sig', () => { // test is broken, only ever passed due to other tests mutating the test data
it('fails for large sig', () => {
const sig = new Uint8Array([...testData.EDDSA_SIG_HEX, 0x00]);
const hashPtr = writeData(vm, testData.EDDSA_MSG_HEX);
const sigPtr = writeData(vm, sig);
Expand Down