Skip to content
This repository was archived by the owner on Mar 8, 2019. It is now read-only.

Patch for #9 #10 #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patch for #9 #10 #11

wants to merge 3 commits into from

Conversation

@nodtem66
Copy link
Contributor

Patch #9:

  • The emptiness of any function is false
empty( function() {} ); // false
empty( function() {return 0;} ); // false

Patch #10:

  • Propose a new method to assert the emptiness of objects. both for...in and Object.keys() return only enumerable properties, whereas Object.getOwnPropertyNames() lists all enumerable and non-enumerable properties. see: MDN
  • Propose the TDD running in browser (NEED REVIEW)
    • npm build:test browsify test/index.js to test/browser.index.js
    • open test/runner.html (no webserver required)

@nodtem66
Suggestion, due to ianstormtaylor#9 (The empty of functions)
61d9d91
@nodtem66
Fixed ianstormtaylor#10
bc9398a 
- add mocha for browser (NEED REVIEW)
  - create `runner.html`
  - build `browser.index.js` from browserify
- fixed isEmpty(Object) by check length of
  `Object.getOwnPropertyNames`
@nodtem66
change empty(0) -> false
77f3389
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nodtem66