Skip to content

Conversation

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR revamps the notifications functionality and introduces new sidebar interactions while updating related configuration and routing. Key changes include:

  • Introducing a new sidebar panel with improved event handling and backdrop management.
  • Revamping notifications modal and list functionality by adding support for actions such as marking notifications as read/unread, bulk operations, and deletion.
  • Updating routing, service configurations, and default settings to support the new notifications features.

Reviewed Changes

Copilot reviewed 27 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/bundle/Resources/public/js/scripts/sidebar/side.panel.js New sidebar panel implementation with close triggers and backdrop control.
src/bundle/Resources/public/js/scripts/admin.notifications.modal.js Updates to notifications modal including new actions and improved event management.
src/bundle/Resources/public/js/scripts/admin.notifications.list.js Introduction of notifications list with bulk operations and status management.
src/bundle/Resources/public/js/scripts/admin.notifications.filters.js New filters implementation for notifications.
src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js Improvement in multilevel popup menu initialization with refactored event handling.
src/bundle/Resources/encore/ibexa.js.config.js Updated configuration to include new notifications list entry.
src/bundle/Resources/config/services/controllers.yaml Added new controller service definitions for notifications.
src/bundle/Resources/config/routing.yaml Introduced new routes to support notifications actions.
src/bundle/Resources/config/ezplatform_default_settings.yaml Increased pagination limit for notifications.
Files not reviewed (11)
  • src/bundle/Controller/AllNotificationsController.php: Language not supported
  • src/bundle/Controller/NotificationController.php: Language not supported
  • src/bundle/Form/Data/SearchQueryData.php: Language not supported
  • src/bundle/Form/Type/SearchType.php: Language not supported
  • src/bundle/Resources/public/scss/_header-user-menu.scss: Language not supported
  • src/bundle/Resources/public/scss/_list-filters.scss: Language not supported
  • src/bundle/Resources/public/scss/_notifications-modal.scss: Language not supported
  • src/bundle/Resources/public/scss/_notifications.scss: Language not supported
  • src/bundle/Resources/public/scss/_side-panel.scss: Language not supported
  • src/bundle/Resources/public/scss/ibexa.scss: Language not supported
  • src/bundle/Resources/translations/ibexa_admin_ui.en.xliff: Language not supported
Comments suppressed due to low confidence (1)

src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js:2

  • [nitpick] The function name 'initMutlilevelPopupMenus' appears to contain a typographical error; consider renaming it to 'initMultilevelPopupMenus' for clarity.
const initMutlilevelPopupMenus = (container) => {

@tbialcz tbialcz force-pushed the ibx_9060 branch 2 times, most recently from 106b699 to 46edda7 Compare April 29, 2025 07:41
@albozek albozek force-pushed the ibx_9060 branch 2 times, most recently from 485f3de to d537c29 Compare April 29, 2025 12:58
@tbialcz tbialcz requested a review from ViniTou August 29, 2025 07:17
@barbaragr
Copy link
Contributor

barbaragr commented Aug 29, 2025

  1. [FIXED] yarn issues after checking out.

  2. If all notifications are marked as read, right corner button should be inactive like the one in table:

Screenshot 2025-08-29 at 14 53 10
  1. Collaboration notifications need adjustments on the list and side bar:
Screenshot 2025-08-29 at 13 07 16 Screenshot 2025-08-29 at 12 32 12
  1. Collaboration type is missing in filters?
Screenshot 2025-08-29 at 12 34 14
  1. [FOLLOW-UP: IBX-10556 ] Jumping while opening/closing filters:
    https://github.com/user-attachments/assets/5ed238aa-8f48-4cc9-a7ef-3451ce660e6f

  2. [FOLLOW-UP: IBX-10575 ] Type in dropdown looks misaligned a little.

  3. [FOLLOW-UP: IBX-10574 ] Dates are not cleared in filters (tested on Firefox, notice that one date is in future):
    https://github.com/user-attachments/assets/3bc9d720-3082-469a-b0ba-5bb2df0178fd

  4. No shade under filter's part of the table:

no_shade

Figma design:

shade in figma
  1. Part of notification is cut when content name is too long:
Screenshot 2025-08-29 at 14 55 51
  1. Go to Content button doesn't work:
nothing happens go to content
  1. Side bar: user should be able to click the notification and then should be redirected to the proper content, notification should be marked as read. If content was deleted, notification should be just marked as read when clicked.

  2. Red information should be displayed in full:

Screenshot 2025-08-29 at 14 57 28
  1. [FIXED with yarn ] Send to review is broken. View after typing the reviewer

  2. Marking as read/unread in side bar doesn't work properly - dot colour is not changing.

Screenshot 2025-08-29 at 15 56 31

@barbaragr
Copy link
Contributor

barbaragr commented Sep 2, 2025

  1. Filtering Notifications list affects sidebar. Sidebar should display last 10 notifications and should not be affected by any filtering set on the list. See attachment below:

https://github.com/user-attachments/assets/9024b652-873e-4a15-b6a7-61dd955d19cb
Screenshot 2025-09-01 at 15 22 41

  1. Go to content doesn’t work if I click publish on an article that was in a content review request. I’m sending a video with the reproduction steps.
go.to.content.mov

Copy link

sonarqubecloud bot commented Sep 2, 2025

@albozek albozek requested a review from GrabowskiM September 2, 2025 12:28
Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved 🥳
Regression: ibexa/commerce#1486

@adamwojs adamwojs merged commit 4c92ca8 into 4.6 Sep 4, 2025
29 checks passed
@adamwojs adamwojs deleted the ibx_9060 branch September 4, 2025 05:16
ViniTou pushed a commit that referenced this pull request Sep 15, 2025
OstafinL pushed a commit that referenced this pull request Oct 7, 2025
barbaragr pushed a commit that referenced this pull request Oct 15, 2025
barbaragr pushed a commit that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.