IBX-9807: Introduce date range single component #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
GrabowskiM,
OstafinL,
RopRaptor,
albozek and
dew326
and removed request for
a team
GrabowskiM
requested changes
Jun 9, 2025
src/bundle/Resources/public/js/scripts/core/date.time.picker.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/core/date.time.range.single.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/core/date.time.range.single.js
Outdated
Show resolved
Hide resolved
OstafinL
approved these changes
Jun 9, 2025
tischsoic
force-pushed
the
ibx-9807-adjusted-time-filters
branch
2 times, most recently
from
578f7a1 to
7c1454c
Compare
GrabowskiM
approved these changes
Jun 17, 2025
dew326
approved these changes
Jun 17, 2025
konradoboza
changed the title
ViniTou
approved these changes
Jun 26, 2025
KamilSznajdrowicz
requested changes
Jun 26, 2025
|
The issue should be fixed @KamilSznajdrowicz, please retest. |
KamilSznajdrowicz
requested changes
Jun 27, 2025
There was a problem hiding this comment.
More bugs in search and with custom range:
- When I enter a keyword in the search input and click "Search", the system automatically sets today’s date (27/06/2025) as the value for both "Last Modified" and "Created" filters — even though I didn’t select any date.
Clicking "Clear" does not remove these date values, and the search remains filtered by today’s date.
I’ve attached a recording of the issue and a comparison with another environment where the filters reset correctly.
Nagranie.z.ekranu.2025-06-27.o.15.54.45.mov
- When I set a custom date range in the "Last Modified" or "Created" filter, the "Apply" button remains disabled and cannot be clicked — even though a valid date range has been selected.
Nagranie.z.ekranu.2025-06-27.o.16.02.17.mov
- In the Search, Trash, and Discounts views, when selecting a custom date range, the selected time shifts 2 hours earlier than intended — even though my timezone is correctly set to Europe/Warsaw.
Nagranie.z.ekranu.2025-06-29.o.15.07.41.mov
tischsoic
requested review from
GrabowskiM,
KamilSznajdrowicz,
OstafinL and
dew326
tischsoic
force-pushed
the
ibx-9807-adjusted-time-filters
branch
from
0adef4a to
1ae8916
Compare
KamilSznajdrowicz
requested changes
Jul 2, 2025
There was a problem hiding this comment.
@tischsoic hi :) last modified works but I have still issue with Created:
- When I set the "Created" filter to "last week" and then click "Clear," the filter value does not get removed. The "Created" filter remains set, and the search continues to be filtered by that date range instead of resetting.
created.not.delete.mov
- When I set a custom date range in the "Created" filter, the "Apply" button remains disabled and cannot be clicked
crated.custom.range.mov
tischsoic
force-pushed
the
ibx-9807-adjusted-time-filters
branch
from
1ae8916 to
e2de6e0
Compare
KamilSznajdrowicz
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Thanks for fixes!
QA Approved
Regression ibexa/commerce#1357
konradoboza
changed the title
|
GrabowskiM
approved these changes
Jul 3, 2025
| const { periodSelector, endSelector } = lastModifiedDateRangeNode.dataset; | ||
| const lastModifiedPeriodValue = doc.querySelector(periodSelector).value; | ||
| const lastModifiedEndDate = doc.querySelector(endSelector).value; | ||
| const lastModifiedStartDateValue = lastModifiedStartDate.value; |
There was a problem hiding this comment.
nitpick - not sure if we need this kind of variables, where you just assign property from object. :)
dew326
approved these changes
Jul 3, 2025
albozek
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: