IBX-10064: Fix notification close removes focus from dropdown #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
GrabowskiM,
OstafinL,
RopRaptor,
albozek and
dew326
and removed request for
a team
tischsoic
commented
Jun 13, 2025
| notificationsContainer.append(notificationNode); | ||
|
|
||
| if (timeout) { | ||
| global.setTimeout(() => notificationNode.querySelector('.ibexa-alert__close-btn').click(), timeout); |
There was a problem hiding this comment.
Note: clicking on this button causes it to focus, which means that the focus was taken (if present on any) from another element. In case of a reported bug, the other element was the dropdown.
dew326
approved these changes
Jun 13, 2025
OstafinL
approved these changes
Jun 16, 2025
albozek
approved these changes
Jun 16, 2025
|
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: