Skip to content

Conversation

@tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Jun 17, 2025

🎫 Issue IBX-10145

Description:

For QA:

This change affects all toggles in the system, not only in discounts.

Documentation:

@tischsoic tischsoic requested a review from a team June 17, 2025 13:35
@tischsoic tischsoic self-assigned this Jun 17, 2025
@ezrobot ezrobot requested review from GrabowskiM, OstafinL, RopRaptor, albozek and dew326 and removed request for a team June 17, 2025 13:35
@sonarqubecloud
Copy link

@KamilSznajdrowicz KamilSznajdrowicz force-pushed the IBX-10145-ibexa-toggle-clickable-area branch from 1cf9ade to 9f9a843 Compare July 24, 2025 12:23
@sonarqubecloud
Copy link

Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :)
Currently, the button also triggers when I click on the label above — "Permanent discount"

Nagranie.z.ekranu.2025-07-24.o.14.36.41.mov

In my opinion, it should only work when clicking directly on the toggle switch.

@KamilSznajdrowicz
Copy link
Contributor

KamilSznajdrowicz commented Jul 25, 2025

Hi :) Currently, the button also triggers when I click on the label above — "Permanent discount"

Nagranie.z.ekranu.2025-07-24.o.14.36.41.mov

In my opinion, it should only work when clicking directly on the toggle switch.

Reported to design team - in some places the label is clickable and toggles the switch, while in others it’s not

Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved

@adamwojs adamwojs merged commit dd6c5a6 into 4.6 Jul 25, 2025
28 checks passed
@adamwojs adamwojs deleted the IBX-10145-ibexa-toggle-clickable-area branch July 25, 2025 13:01
@tischsoic
Copy link
Contributor Author

Merged up:

@tischsoic
Copy link
Contributor Author

tischsoic commented Jul 28, 2025

Regarding:

Reported to design team - in some places the label is clickable and toggles the switch, while in others it’s not

We discussed it in private last week. From what I have checked, it is done by design by symfony/twig-bridge/Resources/views/Form/bootstrap_5_layout.html.twig and I would not consider this to be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants