IBX-6770: "All functions" policy spelling fix #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes the display of “All functions” when a policy’s function value is literally all_functions rather than *.
- Extend the Twig conditional to catch the literal
all_functions(case-insensitive). - Preserve existing handling for
*.
Comments suppressed due to low confidence (1)
src/bundle/Resources/views/themes/admin/user/policy/list.html.twig:27
- Consider adding a test for the case where
policy.functionis set to'all_functions'(in any case) to ensure this path renders the expected translation.
{ content: policy.function == '*' or policy.function|lower == 'all_functions' ? ('role.policy.all_functions')|trans({}, 'forms')|desc('All functions') : policy.function|capitalize },
src/bundle/Resources/views/themes/admin/user/policy/list.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/user/policy/list.html.twig
Outdated
Show resolved
Hide resolved
albozek
force-pushed
the
IBX-6770-policy-spelling
branch
from
fa8e463 to
b01f9cf
Compare
|
GrabowskiM
approved these changes
Jul 11, 2025
tischsoic
approved these changes
Jul 11, 2025
dew326
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: