Skip to content

IBX-6662: Handled re-positioning date picker on scroll #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 4.6
merged 3 commits into from
Aug 7, 2025
Merged

IBX-6662: Handled re-positioning date picker on scroll #1654

merged 3 commits into from
Aug 7, 2025

Conversation

@albozek
Copy link
Contributor

@albozek albozek commented Jul 25, 2025

🎫 Issue IBX-6662

Description:

For QA:

Documentation:

@albozek albozek requested a review from a team July 25, 2025 10:32
@ezrobot ezrobot requested review from GrabowskiM, OstafinL, RopRaptor, dew326 and tischsoic and removed request for a team July 25, 2025 10:32
tischsoic
tischsoic approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@tischsoic tischsoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the problem may be solved by changing CSSes on our side instead of doing this programmatically.

@albozek
Copy link
Contributor Author

albozek commented Jul 31, 2025 •
edited
Loading

I wonder whether the problem may be solved by changing CSSes on our side instead of doing this programmatically.

Discussed internally. There are some issues with using flatpickr options due to the use of the overflow: hidden in some places.

@KamilSznajdrowicz KamilSznajdrowicz force-pushed the IBX-6662-picker-on-scroll branch from b87a29b to 6746676 Compare August 4, 2025 13:24
KamilSznajdrowicz
KamilSznajdrowicz requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :)
Unfortunately, I still have the error from the ticket.

Nagranie.z.ekranu.2025-08-5.o.10.51.28.mov

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KamilSznajdrowicz KamilSznajdrowicz mentioned this pull request Aug 6, 2025
Closed
KamilSznajdrowicz
KamilSznajdrowicz approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved
Regression: ibexa/commerce#1462

@dew326 dew326 merged commit d603358 into 4.6 Aug 7, 2025
29 checks passed
@dew326 dew326 deleted the IBX-6662-picker-on-scroll branch August 7, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@OstafinL OstafinL OstafinL approved these changes

@KamilSznajdrowicz KamilSznajdrowicz KamilSznajdrowicz approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@RopRaptor RopRaptor Awaiting requested review from RopRaptor

Assignees

@dew326 dew326

Labels

QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albozek @tischsoic @dew326 @OstafinL @KamilSznajdrowicz