Skip to content

Conversation

@OstafinL
Copy link
Contributor

@OstafinL OstafinL commented Aug 1, 2025

🎫 Issue IBX-10417

Description:

In this PR I updated create/edit header for content on the fly and create user header and the user creation header.

Content on the fly
Screenshot 2025-08-01 at 10 43 47

User create
Screenshot 2025-08-01 at 10 43 18

For QA:

Documentation:

@OstafinL OstafinL requested a review from a team August 1, 2025 09:00
@OstafinL OstafinL added Bug Something isn't working Ready for review labels Aug 1, 2025
@ezrobot ezrobot requested review from GrabowskiM, RopRaptor, albozek, dew326 and tischsoic and removed request for a team August 1, 2025 09:00
@lserwatka lserwatka self-requested a review August 1, 2025 09:12
@lserwatka
Copy link
Contributor

The design looks great now. Thanks for fixing this quickly.

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some inconsistencies with user editing.

  1. In Admin/Users, user editing still has Location: X instead of under: X.
Screenshot 2025-08-04 at 09 29 21
  1. In UDW, user editing has visible tags.
Screenshot 2025-08-04 at 09 30 37

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved, second issue will report separately - this information was visible there even before the design change
reported here: https://issues.ibexa.co/browse/IBX-10426

@dew326 dew326 merged commit 1596d15 into 4.6 Aug 4, 2025
29 checks passed
@dew326 dew326 deleted the IBX-10417 branch August 4, 2025 09:28
@lserwatka
Copy link
Contributor

@NataliaBecla @dew326, could you discuss two issues reported by @katarzynazawada? We should address these inconsistencies now.

@IdaDraM
Copy link

IdaDraM commented Aug 4, 2025

We should update all screens with "under" without ":" instead of "Location:".
Also, all the time we should use one template, no matter in which flow user is (on the fly, UDW, regular content creation)

@lserwatka
Copy link
Contributor

Question also about the buttons, why do we see different labels on the buttons "Update | Cancel" vs "Save and close | Discard"? @NataliaBecla @dew326

@IdaDraM
Copy link

IdaDraM commented Aug 5, 2025

This is also a left over from simplified actions feature, need to be reported to fix. @katarzynazawada do we have it already reported?

@katarzynazawada
Copy link
Contributor

I couldn't find such a ticket in jira - reported new one: https://issues.ibexa.co/browse/IBX-10442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working QA approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants