Skip to content

IBX-9727: Refactored Form Types and limitation-related code to be aligned with PHP8 #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

IBX-9727: Refactored Form Types and limitation-related code to be aligned with PHP8 #1694

merged 3 commits into from
Sep 3, 2025

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Sep 1, 2025 •
edited
Loading

🎫 Issue IBX-9727

Related PRs:

Description:

Behat tests fail due to lack of dependencies. We should rely on the result of regressions instead: ibexa/commerce#1489 ✅

For QA:

Documentation:

@konradoboza konradoboza self-assigned this Sep 1, 2025
@konradoboza konradoboza force-pushed the introduced-type-hints-lib branch from 6670e7b to 13f10bd Compare September 2, 2025 07:02
@konradoboza konradoboza changed the title IBX-9727: Refactored Form Types to be aligned with PHP8 Refactored Form Types and limitation-related code to be aligned with PHP8 Sep 2, 2025
@konradoboza konradoboza force-pushed the introduced-type-hints-lib branch from 13f10bd to 5d63825 Compare September 2, 2025 07:04
@konradoboza konradoboza mentioned this pull request Sep 2, 2025
Closed
@konradoboza konradoboza changed the title Refactored Form Types and limitation-related code to be aligned with PHP8 IBX-97272: Refactored Form Types and limitation-related code to be aligned with PHP8 Sep 2, 2025
@konradoboza konradoboza changed the title IBX-97272: Refactored Form Types and limitation-related code to be aligned with PHP8 IBX-9727: Refactored Form Types and limitation-related code to be aligned with PHP8 Sep 2, 2025
@konradoboza konradoboza requested a review from a team September 2, 2025 09:11
@ezrobot ezrobot requested review from Steveb-p, ViniTou, adamwojs, alongosz, barw4, ciastektk, mikadamczyk, tbialcz and wiewiurdp and removed request for a team September 2, 2025 09:11
mikadamczyk
mikadamczyk approved these changes Sep 2, 2025
View reviewed changes
@konradoboza konradoboza force-pushed the introduced-type-hints-lib branch from ac72fa8 to bf42ffb Compare September 2, 2025 10:03
ViniTou
ViniTou reviewed Sep 2, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@konradoboza konradoboza requested a review from ViniTou September 2, 2025 11:37
@konradoboza konradoboza merged commit fd7fb2d into main Sep 3, 2025
27 checks passed
@konradoboza konradoboza deleted the introduced-type-hints-lib branch September 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@ViniTou ViniTou ViniTou approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@alongosz alongosz Awaiting requested review from alongosz

@ciastektk ciastektk Awaiting requested review from ciastektk

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@ViniTou ViniTou

@konradoboza konradoboza

Labels

Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@konradoboza @mikadamczyk @Steveb-p @ViniTou @ciastektk