IBX-1439: Refactored SiteAccess-aware Flysystem Adapter to use proxying #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-1439-upgrade-flysystem-use-proxy-adapter
branch
from
1cf25bf to
0e657bc
Compare
kisztof
approved these changes
Jan 10, 2023
alongosz
requested review from
a team,
Steveb-p,
adamwojs,
mikadamczyk and
webhdx
ViniTou
approved these changes
Jan 10, 2023
webhdx
approved these changes
Jan 10, 2023
Member
Author
|
Merging this one into #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4This PR replaces 1:1 copy of Flysystem's Local Adapter with the solution suggested by Flysystem's Maintainer - an Adapter which is decorating Local adapter instances which use
/as filesystem root, allowing to proxy all method calls, prefixing the path with our logic beforehand. See #171 for more details about the suggested solution.Note that given currently SiteAccess dynamic setting
io.root_diris always an absolute path, the inner adapter is going to work only if its prefix is indeed/.TODO:
Checklist:
$ composer fix-cs).