IBX-8697: Added validation for Keyword field type values in content and tests #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
mikadamczyk and
wiewiurdp
and removed request for
a team
Steveb-p
reviewed
Jun 11, 2025
barw4
reviewed
Jun 11, 2025
wiewiurdp
approved these changes
Jun 12, 2025
adamwojs
approved these changes
Jun 15, 2025
konradoboza
requested changes
Jun 16, 2025
konradoboza
reviewed
Jun 16, 2025
…ype safety and removed obsolete PHPStan baseline rules
konradoboza
approved these changes
Jun 16, 2025
alongosz
approved these changes
Jun 17, 2025
barbaragr
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Error 500 does not occur anymore, but after clicking publish button there is page is reloaded, image disappears from field and nothing more happened. I can see that field validation blinks very fast. :)
https://github.com/user-attachments/assets/2552f979-8ae6-4b11-aa50-439a8681ed61
|
If it validates that each keyword is a string should it be possible to type those keywords? |
|
barbaragr
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR introduces validation rules for the Keyword field type values to ensure data integrity within content entries. Specifically: