Skip to content

Conversation

@Steveb-p
Copy link
Contributor

🎫 Issue IBX-10428

Description:

This fix allows invokable commands from Symfony to work properly and not crash the application.

For QA:

Documentation:

@Steveb-p Steveb-p force-pushed the ibx-10428/handle-invokable-commands branch from 4bba6bd to accacab Compare August 13, 2025 10:24
@Steveb-p Steveb-p requested review from a team and Copilot August 13, 2025 10:24
@Steveb-p
Copy link
Contributor Author

If we want, we could add a dummy invokable command to integration tests to ensure that they can be registered properly, but we don't have precedence yet as to where to put things like that.

Copilot

This comment was marked as outdated.

@Steveb-p Steveb-p requested a review from Copilot August 13, 2025 10:28
Copilot

This comment was marked as outdated.

@Steveb-p Steveb-p requested a review from Copilot August 13, 2025 10:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation issue where Symfony's invokable commands (commands without explicit class definitions) were causing container build failures when the compiler pass attempted to add siteaccess options to them.

  • Added class validation to skip invokable commands in the ConsoleCommandPass
  • Updated test to properly define Command class for existing test case
  • Added new test to verify invokable commands are properly skipped

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPass.php Added validation to skip commands without explicit Command class definitions
tests/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPassTest.php Updated existing test and added test case for invokable command handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

@adamwojs adamwojs merged commit 691bfda into main Aug 14, 2025
16 checks passed
@adamwojs adamwojs deleted the ibx-10428/handle-invokable-commands branch August 14, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants