IBX-7844: Tag component #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Tag component for the design system, providing a reusable UI element with multiple visual variants and sizes.
- Adds Tag component with comprehensive type system including primary, success, warning, error, and ghost variants
- Implements responsive sizing (medium/small) and icon support functionality
- Integrates styling system with SCSS mixins and comprehensive visual theming
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/src/components/Tag/index.ts | Exports Tag component and types |
| packages/components/src/components/Tag/Tag.types.ts | Defines TagSize, TagType enums and TagProps interface |
| packages/components/src/components/Tag/Tag.tsx | Main Tag component implementation with conditional rendering |
| packages/components/src/components/Tag/Tag.stories.tsx | Storybook stories for all Tag variants |
| packages/assets/src/scss/styles.scss | Imports tags stylesheet |
| packages/assets/src/scss/mixins/_tags.scss | Tag-specific SCSS mixins |
| packages/assets/src/scss/mixins/_buttons.scss | Refactors button state mixin for reusability |
| packages/assets/src/scss/_tags.scss | Complete Tag component styling with variants and themes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
albozek
force-pushed
the
IBX-7844
branch
2 times, most recently
from
63e6f04 to
02cbe60
Compare
GrabowskiM
requested changes
Oct 14, 2025
GrabowskiM
approved these changes
Oct 15, 2025
dew326
approved these changes
Oct 15, 2025
albozek
commented
Oct 15, 2025
| export const Tag = ({ children, className = '', isDark = false, icon, size = TagSize.Medium, type }: TagProps) => { | ||
| const isGhostType = (tagType: TagType | TagGhostType): tagType is TagGhostType => { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion | ||
| return Object.values(TagGhostType).includes(tagType as TagGhostType); |
There was a problem hiding this comment.
In this case, the use of as to check whether a specific type exists in the enum string cannot be omitted, that's why rule 'no-unsafe-type-assertion' is disabled here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: