Skip to content

IBX-2355: Made inheritance of the naming methods possible #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2022
Merged

IBX-2355: Made inheritance of the naming methods possible #32

merged 4 commits into from
Mar 29, 2022

Conversation

@konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Mar 28, 2022 •
edited
Loading

JIRA: https://issues.ibexa.co/browse/IBX-2355

In order to reuse methods pluralize and toCamelCase within https://github.com/ibexa/product-catalog/pull/456 we need to change their scope to be able to decorate the original implementation and avoid redundancy.

@konradoboza konradoboza self-assigned this Mar 28, 2022
@konradoboza konradoboza requested a review from webhdx March 28, 2022 12:30
@adamwojs
Copy link
Member

In order to reuse methods pluralize and toCamelCase within https://github.com/ibexa/product-catalog/pull/456 we need to change their scope to be able to decorate the original implementation and avoid redundancy.

IMHO it's worth to consider extracting interface from NameHelper but this could be done as follow up.

@konradoboza konradoboza requested review from adamwojs and webhdx March 28, 2022 13:08
@konradoboza konradoboza force-pushed the ibx-2355-improved-name-helper-inheritance branch from 2d2a0df to b377ddf Compare March 28, 2022 14:04
bdunogier
bdunogier reviewed Mar 28, 2022
View reviewed changes
@konradoboza konradoboza force-pushed the ibx-2355-improved-name-helper-inheritance branch from b377ddf to 0ab6bcb Compare March 28, 2022 15:43
@konradoboza
Copy link
Contributor Author

I reverted access modifiers, introduced an abstract class with common methods that can be accessed in other places, and went for decoupling pluralize method by moving it to a dedicated service. Please re-review @adamwojs @webhdx.

adamwojs
adamwojs approved these changes Mar 29, 2022
View reviewed changes
@konradoboza konradoboza force-pushed the ibx-2355-improved-name-helper-inheritance branch from b22ca14 to 149c00a Compare March 29, 2022 10:53
@adamwojs adamwojs merged commit b663757 into main Mar 29, 2022
@adamwojs adamwojs deleted the ibx-2355-improved-name-helper-inheritance branch March 29, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx Awaiting requested review from webhdx

+1 more reviewer

@bdunogier bdunogier bdunogier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@konradoboza konradoboza

Labels

Improvement Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@konradoboza @adamwojs @bdunogier @webhdx