IBX-6620: Added Image criterion visitors #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
3 times, most recently
from
9168822 to
8653d48
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
from
8653d48 to
1dd102e
Compare
6 tasks
ciastektk
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
from
1dd102e to
edfd05e
Compare
ciastektk
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
2 times, most recently
from
bde5054 to
aa82131
Compare
ViniTou
approved these changes
Nov 8, 2023
| deprecated: | ||
| version: 'eZ Platform 3.2.0' | ||
| package: 'ibexa/solr' | ||
| message: 'The "%service_id%" service is deprecated since eZ Platform 3.2.0, to be removed in eZ Platform 4.0.0., use ezpublish.search.solr.result_extractor.content.native or ezpublish.search.solr.result_extractor.location.native instead.' |
Contributor
There was a problem hiding this comment.
If you are touching those, I think we can also change the version (and name) when this gonna be removed.
ciastektk
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
2 times, most recently
from
90ed0c1 to
a041631
Compare
konradoboza
approved these changes
Nov 16, 2023
| return $criterion instanceof Criterion\Image\Height | ||
| && ( | ||
| $criterion->operator === Operator::BETWEEN | ||
| || $criterion->operator === Operator::GTE |
Contributor
There was a problem hiding this comment.
Wouldn't also make sense to have Operator::LTE here?
| return $criterion instanceof Criterion\Image\Width | ||
| && ( | ||
| $criterion->operator === Operator::BETWEEN | ||
| || $criterion->operator === Operator::GTE |
Contributor
There was a problem hiding this comment.
Same remark as for Height.
kisztof
approved these changes
Nov 20, 2023
webhdx
force-pushed
the
ibx-6620-added-image-criterion-visitors
branch
from
a041631 to
2012855
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6This PR adds CriterionVisitors for Image criteria that enables image search in solr engine:
There is also added dedicated IbexaTestKernel class for integration tests.
Checklist:
$ composer fix-cs).@ibexa/php-devfor back-end changes and/or@ibexa/javascript-devfor front-end changes).