Skip to content

Refactored Code with Typed Properties and Constructor Promotion via Rector #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactored Code with Typed Properties and Constructor Promotion via Rector #65

wants to merge 3 commits into from

Conversation

@tbialcz
Copy link
Contributor

@tbialcz tbialcz commented Feb 28, 2025

🎫 Issue IBX-XXXXX

Description:

  • Applied TypedPropertyFromAssignsRector to infer and enforce typed properties.
  • Used ClassPropertyAssignToConstructorPromotionRector to simplify property assignments with constructor promotion.
  • Enabled SetList::TYPE_DECLARATION to enforce strict type declarations across the codebase.

For QA:

Documentation:

@tbialcz tbialcz requested a review from a team February 28, 2025 08:28
konradoboza
konradoboza reviewed Feb 28, 2025
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konradoboza konradoboza konradoboza left review comments

Assignees

@alongosz alongosz

@ciastektk ciastektk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbialcz @konradoboza @alongosz @ciastektk