IBX-10507: Allowed nullable type declarations for method parameters across the codebase #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
konradoboza
approved these changes
Sep 23, 2025
barw4
reviewed
Sep 24, 2025
| */ | ||
| public function resetUserPassword( | ||
| UserPasswordResetData $data = null, | ||
| ?UserPasswordResetData $data = null, |
There was a problem hiding this comment.
Can't we enforce $data to be just UserPasswordData without null if we really don't support null?
In the user package it's executed only in 1 place where $data is not null
There was a problem hiding this comment.
You are right, but for the sake of efficiency let's stick to original task which is (getting rid of deprecated syntax instead of evaluating each case separately) 😉
adamwojs
approved these changes
Oct 1, 2025
adamwojs
reviewed
Oct 1, 2025
Comment on lines
55
to
57
| if ($data->getEmail() === null){ | ||
| throw new InvalidArgumentException('Email cannot be null'); | ||
| } |
There was a problem hiding this comment.
Because of phpstan Error:
------ ------------------------------------------------------------------------------------------------------------------------------------
Line src/bundle/Controller/UserInvitationController.php
------ ------------------------------------------------------------------------------------------------------------------------------------
58 Parameter #1 $email of class Ibexa\Contracts\User\Invitation\InvitationCreateStruct constructor expects string, string|null given.
🪪 argument.type
------ --------------------------------------------------------------------
added 3 commits
October 1, 2025 16:33
…d unused import in UserInvitationController
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allowed nullable type declarations for method parameters across the codebase