Move most uses of the std crate to core and alloc #196
+51
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::io and std::error::Error are the two remaining uses of std preventing this crate from building in a #![no_std] context. I’ve tried reimplementing just these parts of std in this crate, but it was obviously not a good way forward, and I don’t know what could be a way forward here. In the meantime, these changes don’t cause any issue, and will be useful for the next person trying to implement no_std! f32::ceil() and f32::fract() are two other functions we use which are available only in std, I’m not too sure why.
linkmauve
force-pushed
the
almost-no_std
branch
from
4a6e2aa to
fcba84b
Compare
197g
approved these changes
Oct 5, 2021
wartmanm
pushed a commit
to wartmanm/jpeg-decoder
that referenced
this pull request
Sep 15, 2022
Move most uses of the std crate to core and alloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::ioandstd::error::Errorare the two remaining uses ofstdpreventing this crate from building in a#![no_std]context.I’ve tried reimplementing just these parts of
stdin this crate, but it was obviously not a good way forward, and I don’t know what could be a way forward here. In the meantime, these changes don’t cause any issue, and will be useful for the next person trying to implementno_std!f32::ceil()andf32::fract()are two other functions we use which are available only instd, I’m not too sure why.