Admit more precision values in JPEG Lossless #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to make room for other data sets under different conditions - tweak data set README
- accept precision between 2 and 16 if coding process is lossless - map more frame precision values to the right `PixelFormat`
- covers 12-bit and 10-bit precision lossless JPEG decoding
|
If there is something I can do to help this get merged, please let me know. JPEG lossless is not supported by any other JPEG decoder written in Rust at the moment, and this feature is particularly important for the DICOM-rs project. |
|
Sorry for the delay on this! |
|
Hello again! There hasn't been a crate release for this and other changes made in 2023. Is there a chance that this could be done eventually? Much appreciated! 🙏 In the meantime, I have already reached out to zune-jpeg to see how to incorporate JPEG lossless decoding there (etemesi254/zune-image#144), but it might take some time before I or anyone else can pick this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the implementation of JPEG lossless originally provided in #193 can also handle sample precision values other than 8 and 16. The standard itself covers the lossless coding between 2 and 16 bits of sample precision. This PR relaxes the frame precision check to let the algorithms proceed in this particular case. I also added some public test files with 10 bits and 12 bits of precision for validation.
Summary
2..=16when coding process is lossless (continues to accept only 8 bits otherwise)