Simplify github actions CI yaml file to use stock github runners and latest versions of windows/mac/ubuntu #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 windows, always on the latest version of the os/runners that github gives us
grdanny
changed the title
grdanny
changed the title
lgritz
reviewed
Jun 23, 2025
lgritz
approved these changes
Jun 23, 2025
Member
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
LGTM, modulo the comment about specifying actions by SHA hash
… of a tag, a tag can be moved around, but a sha can't so it's more stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to simplify the pystring CI setup.
The idea here is to use the stock github runners, one for linux, one for mac and one for windows.
Whatever they give us as latest.
Which I hope would be enough for pystring.
If this doesn't prove successful we can try to maybe take an example from one of the ASWF projects that use the aswf docker images and see if we can simplify that.