feat: add TRID label (GE interpreter). #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi all, I just noticed that there was a "np.NaN" instead of "np.nan" which is now deprecated in the new Numpy 2.0 release (from 2 days ago). I have now fixed this |
Collaborator
|
Thanks for the NaN fix, was going to do it in a separate PR! Not sure why it's not running the unit tests now, but I don't expect any issue with an additional label. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "TRID" label (see pulseq/pulseq@682b9f1) to allow the GE interpreter to optimize the sequence by grouping consecutive blocks, removing the dead times between them. This is required to allow accurate execution of sequences designed for Siemens systems on GE systems.