-
Notifications
You must be signed in to change notification settings - Fork 74
fix test_report() so it also works when there are noise scans #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test_report() so it also works when there are noise scans #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would prefer not to change the gre_label example sequence, because this is probably the most copied sequence code and adding a noise acquisition here might result in new users thinking this is necessary.
Instead, I added another test sequence (seq5) which mimics a gre sequence with preceding noise acquisition and labels and added the other test sequences seq1-seq5 to your test_report test.
If you are fine with this solution, I would ask you to revert the change in the write_gre_label script and corresponding seq-file.
If you prefer to have the noise acquisition included in a real example sequence, I would vote to add another sequence instead of changing the gre_label sequence.
Having a separate seq5 for testing is fine for me. I remove the changes to the write_gre_label script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all fine now
If there are ADC samples before a RF pulse, then the
test_report
fails. This was fixed in pulseq in this PR:https://github.com/pulseq/pulseq/pull/85/files
Not sure if modifying
write_GRE_label
is the best choice, happy to adapt it. I also added a test to runtest_report
on all example scripts. This does not seem to take too much longer.