Proof of issue fix -- demonstrated with rebase on in-progress arrow upgrade. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tison <[email protected]>
… alamb/update_prost
…ll solve the issue
github-actions
bot
added
documentation
Author
|
No longer needed -- this was a temporary PR to demonstrate that another PR was the proper fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a PR over here which is using view-type statistics support which is not yet in the current arrow release.
Instead, this PR is taking the in-progress planned arrow upgrade, then cherry-picked over the original PR commits -- to prove that we do resolve the issue once the arrow release is in. 🎉
Also added one last commit to remove the previously panicking tests, since it no longer panics once the arrow release goes in.